Menu

#Jakeworth

1 post

Feed
1 of 1 post
On commenting and approving pull requests
📰
0Read More

On commenting and approving pull requests

Hacker News·6 months ago
#0qugzJk6
#jakeworth#comments#code#comment#approve

After reviewing a lot of pull requests, I’ve settled on a simple default: if my comments are all nitpicks, suggestions, questions, or non-blocking issues, I leave them and approve the PR at the same time.

15s