Menu

Code review as dialogue: what Paulo Freire taught me about mentoring developers
📰

Code review as dialogue: what Paulo Freire taught me about mentoring developers

DEV Community: career·Karen Molina·7 days ago
#8SH1YWgT
#devtocareer#devto#dev#review#comment
Reading 0:00
15s threshold

Here's a code review comment I've received more than once, and, honestly, written more than once:

Change this to use useMemo .

It's correct. It's fast. The PR gets merged. And the junior who wrote it learns exactly one thing: that a senior person wanted useMemo there.

Next week, they'll ask again. Or worse, they'll start adding useMemo everywhere.

The banking model of code review

In Pedagogy of the Oppressed (1968), the Brazilian educator Paulo Freire described what he called the banking model of education . The teacher knows; the student doesn't. The teacher makes "deposits" of knowledge, and the student's job is to receive, store and repeat them.

Freire's problem with it wasn't only that it's boring.…

Continue reading — create a free account

Join HashtagPLUS to read full articles, follow hashtags, vote, and join the conversation.