Menu

What I Learned from Reviewing Someone Else's Pull Request in Zalando Logbook
📰

What I Learned from Reviewing Someone Else's Pull Request in Zalando Logbook

DEV Community: career·VINAYAK GOTE·6 days ago
#Ow4ptrV5
#devtocareer#devto#dev#code#level
Reading 0:00
15s threshold

Most open source advice is about sending your own PRs. I want to write about the other side: reviewing someone else's. I learned as much from one review thread as from several of my own PRs.

How it started

I had added status-code based logging to Logbook earlier ( PR #2301 ). Then another contributor found that it did not work with the ECS log format and opened issue #2378 , followed by PR #2379 to fix it.

It was a gap in my own earlier work. I did not want to send a competing PR, since the fix was already in progress. So I did the useful thing: I reviewed it.

What I checked

I read the PR with two simple questions: does it do what it says, and does it match the code around it?

I left two comments:

Thresholds. Does the new ECS sink use the same rules as the existing writer for choosing TRACE, WARN or ERROR, or is that logic written a second time? If it is a copy, the two can drift apart later when someone changes one of them.…

Continue reading — create a free account

Join HashtagPLUS to read full articles, follow hashtags, vote, and join the conversation.