Menu

Our two person rule for production deploys let people approve their own runs
📰

Our two person rule for production deploys let people approve their own runs

DEV Community: cicd·Sergey Shinder·7 days ago
#V8oKc3n4
#devtocicd#devto#dev#person#production
Reading 0:00
15s threshold

Our deploy workflow runs on every push to main, and its production job names an environment called production. The environment has required reviewers, a team of six senior engineers, so the job waits until one of them presses Approve. In our security policy that is written down as a two person rule: nobody can put a change into production alone.

In September an internal audit sampled three months of deployments and pulled the approval history for each run from the API. Of 214 production deploys, 58 had been approved by the same person who had merged the pull request and so started the run. Most were small and harmless. One of them was a change to our refund limits that had been merged on a Friday evening without a code review, because branch protection on that repository had been loosened during an incident in July and never tightened again.

Nothing had been bypassed.…

Continue reading — create a free account

Join HashtagPLUS to read full articles, follow hashtags, vote, and join the conversation.