Menu

Your Login Limit Counted Attempts per IP and Read the IP the Attacker Wrote
📰

Your Login Limit Counted Attempts per IP and Read the IP the Attacker Wrote

DEV Community: node·Serguey Asael Shinder·4 days ago
#lCeoJjHe
#devtonodejs#devto#dev#address#balancer
Reading 0:00
15s threshold

The login form

had a sensible guard.

Five failed attempts

per IP address per minute.

After that,

wait.

The app ran behind a load balancer,

so every connection

came from the balancer's own address.

Every user would have shared

one limit.

Somebody fixed that

with one line.

app.set('trust proxy', true)

Now req.ip

showed the real client.

The logs looked right.

The tests passed.

Months later

the security team found

forty thousand guesses

against one account

in a single night.

The limiter

had not blocked one of them.

Every request

had come from a different IP.

None of those IPs

had sent anything.

Here is the mechanism.

A load balancer

tells the app who connected

by adding a header.

X-Forwarded-For.

If the request

already has one,

the balancer does not replace it.

It appends

the address it actually saw

to the end.

So the header is a list.

On the right,

what your own proxy wrote.

On the left,

whatever the client claimed.

With trust proxy set to true,

Express takes the…

Continue reading — create a free account

Join HashtagPLUS to read full articles, follow hashtags, vote, and join the conversation.