The pull request was titled "Add People You May Know widget". It had one new endpoint, one SQL query, and a screenshot of ten smiling suggestions from the staging database. The tests passed. The demo looked great.
I sent it back anyway, with six comments. None of them said the query was wrong. It returns exactly the right people for a user with 40 friends. The problem is everyone else, and everything that happens after the first page load.
Here's the review, comment by comment, with the shape of what I asked for in .NET 10. The code is trimmed on purpose. Where a part is cut, it says so.
Tech Skill Builder is $5/month for a very limited time only (normally $10). Grab it now before it goes back to $10. The complete, working, tested project behind this review ( facebook-people-you-may-know-dotnet , Clean Architecture, 164 tests, plus an 87-page PDF) is inside. Join Tech Skill Builder
The PR as submitted
-- GET /users/{me}/suggestions SELECT f2 .…