Menu

A One-Line Devcontainer Fix for LibreSign, Scoped Down in Review
📰

A One-Line Devcontainer Fix for LibreSign, Scoped Down in Review

DEV Community: docker·Robert Markovski·about 1 hour ago
#vuHaUGoJ
#devtodocker#devto#dev#nextcloud#setup
Reading 0:00
15s threshold

Sometimes the best review outcome is a smaller pull request.

Short answer

LibreSign's devcontainer pulled Nextcloud master, which requires PHP 8.3, but defaulted to a PHP 8.2 image, so a clean setup never finished installing. The merged fix changes the default image to PHP 8.3. A second change, making setup.sh fail hard on any error, was dropped at the maintainer's request. It was merged as PR #8001 and closed issue #7985 .

The problem

LibreSign is a Nextcloud app for digital document signing. Issue #7985 reported that the devcontainer did not produce a working environment on a clean checkout. The first of several chained failures was this one:

This version of Nextcloud requires at least PHP 8.3<br/>You are currently running 8.2.33.…

Continue reading — create a free account

Join HashtagPLUS to read full articles, follow hashtags, vote, and join the conversation.